Drop Python 3.9, test against Python 3.14 preview#665
Merged
Conversation
Cog test failed in CI, but these are case insensitive anyway.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #665 +/- ##
==========================================
- Coverage 95.60% 95.46% -0.15%
==========================================
Files 8 8
Lines 2915 2930 +15
==========================================
+ Hits 2787 2797 +10
- Misses 128 133 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simonw
changed the title
simonw
commented
Oct 1, 2025
Comment on lines
+3296
to
+3299
| def _value_or_none(value): | ||
| if getattr(value, "__class__", None).__name__ == "Sentinel": | ||
| return None | ||
| return value |
Owner
Author
There was a problem hiding this comment.
Codex CLI on GPT-5-Codex suggested this as a workaround for:
Owner
Author
|
It looks like that gross |
Owner
Author
|
I'm going to land this and file a separate ticket to remove the Sentinel hack once Click ship their next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://sqlite-utils--665.org.readthedocs.build/en/665/